Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix window.ethereum usage to avoid phantom pop up #9178

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix window.ethereum usage to avoid phantom pop up #9178

merged 1 commit into from
Sep 11, 2024

Conversation

ianrowan
Copy link
Contributor

Link to Issue

Closes: #9177

Description of Changes

  • Uses the specific metamask provider found in earlier wallet enablement steps to call the switch network command

"How We Fixed It"

  • replaced downstream(beyond finding metamask) usage of window.ethereum

Test Plan

  • Set metamask on wrong network for any transaction(create namespace/stake, etc)
  • ensure switch network pop-up occurs on click

@ianrowan ianrowan linked an issue Sep 10, 2024 that may be closed by this pull request
Phantom pulled up by error when calling switch network for metamask #9177
Closed
@ianrowan ianrowan marked this pull request as ready for review September 10, 2024 19:32
ilijabojanovic
ilijabojanovic approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@ilijabojanovic ilijabojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilijabojanovic ilijabojanovic merged commit 219519e into master Sep 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzparacha mzparacha mzparacha approved these changes

@ilijabojanovic ilijabojanovic ilijabojanovic approved these changes

@masvelio masvelio Awaiting requested review from masvelio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phantom pulled up by error when calling switch network for metamask
3 participants
@ianrowan @ilijabojanovic @mzparacha