-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added external token integration functionality in community integrations #10164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timolegros
reviewed
Dec 9, 2024
…y' into malik.9898.pin-token-in-community
# Conflicts: # libs/model/src/policies/chainEventCreatedPolicy.ts
mzparacha
changed the title
Added token intergation section in community integrations
Added token intergation functionality in community integrations
Dec 11, 2024
mzparacha
changed the title
Added token intergation functionality in community integrations
Added external token integration functionality in community integrations
Dec 11, 2024
Rotorsoft
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (backend) 🚀
masvelio
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
packages/commonwealth/client/scripts/state/api/communities/getPinnedTokenByCommunityId.ts
Outdated
Show resolved
Hide resolved
packages/commonwealth/client/scripts/state/api/communities/getPinnedTokenByCommunityId.ts
Outdated
Show resolved
Hide resolved
...ges/commonwealth/client/scripts/views/pages/CommunityManagement/Integrations/Token/Token.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9898
Description of Changes
Added option to pin tokens to the community. Users can pin any token that is launched externally.
"How We Fixed It"
N/A
Test Plan
Pre-req:
pnpm migrate-db
/:communityId/manage/integrations/token
shows a "Page not found"/:communityId/manage/integrations/token
shows a "Page not found"1. Verify you see the "Add token" section on the integration page if there is not already a token connected to the community
2. Verify you see the "Manage connected token" section on the integration page if there is already a token connected to the community
3. Verify visiting
/:communityId/manage/integrations/token
doesn't show a "Page not found"1.2.2.1
, Click on the "Add token" button, fill the form and add a token ex: add shushi with0x7d49a065d17d6d4a55dc13649901fdbb98b2afba
address./:communityId/manage/integrations
page, the "Add token" section now becomes "Manage connected token" with status indicating that a token is connected to community.1.2.2.2
, Click on the "Manage connected token" buttonDeployment Plan
N/A
Other Considerations
There are some followup tickets that would add related functionality which is not ready to add atm
[Followup #9887 #9898]
: Update community token widget to support pinned tokens. #10233