feat: add about button to header #10228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Closes: #10227 Co-Authored-By: Dillon Chen <[email protected]>
Israellund
approved these changes
Dec 11, 2024
|
@dillchen I would use a different icon and change the color to match the others, otherwise works well |
Co-Authored-By: Dillon Chen <[email protected]>
Co-Authored-By: Dillon Chen <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
devin-ai-integration
bot
force-pushed
the
devin/1733936319-add-about-button
branch
3 times, most recently
from
cb7fc25 to
c5a8a08
Compare
- Remove sidebar-dependent positioning from tooltips - Standardize tooltip arrow positioning using calc(50% - 8px) - Add About Common tooltip to About button with bottom placement - Ensure consistent tooltip alignment across header buttons Co-Authored-By: Dillon Chen <[email protected]>
Button looks too big and doesn't show up on screen size < 600px |
|
Let us hide the button on small and medium screen sizes |
|
Cc: @Israellund |
Co-Authored-By: Dillon Chen <[email protected]>
mzparacha
reviewed
Dec 13, 2024
...commonwealth/client/scripts/views/components/SublayoutHeader/DesktopHeader/DesktopHeader.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Dillon Chen <[email protected]>
|
I am adding also some additional elements to navbar so it is getting tight.
|
Co-Authored-By: [email protected] <[email protected]>
…3936319-add-about-button
… only Co-Authored-By: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated tooltip styling to restore triangle arrow and center tooltips properly.
Link to Devin run: https://app.devin.ai/sessions/f4bfc3c2f1da45f88e2972adbcd84570