Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inter-Community navigation #10258

Merged
merged 9 commits into from
Dec 20, 2024

Conversation

salman-neslit
Copy link
Collaborator

@salman-neslit salman-neslit commented Dec 12, 2024

Link to Issue

Closes: #7989

Description of Changes

  • Display communities the user is a member of in the sidebar on the left-hand side.
  • Highlight the community icon with a blue circle and make it circular when the user is within the community.
  • Display the community icon in a square format when the user is not within the community.
  • Indicate unread content notifications communities.
  • Hide community icons when the user is signed out.

"How We Fixed It"

Test Plan

  • Sidebar visibility of joined communities.
  • Correct icon highlighting when entering and leaving communities.
  • Notifications for unread content in active communities.
    • You can send notification using Knock test workflows.
  • No community icons visible when signed out.

Deployment Plan

Other Considerations

@salman-neslit salman-neslit marked this pull request as ready for review December 20, 2024 14:01
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

have communities duplicated

@salman-neslit
Copy link
Collaborator Author

image

have communities duplicated

@masvelio not really top one is the fav community section

Actions
---- (divider)
Favs
---- (divider)
All

@masvelio
Copy link
Contributor

image
have communities duplicated

@masvelio not really top one is the fav community section

Actions ---- (divider) Favs ---- (divider) All

@dillchen is this expected? Does not look good when I was clicking it

… into salman/Issue#7989/inter-community-navigation
@salman-neslit salman-neslit merged commit 9249a26 into master Dec 20, 2024
10 checks passed
@dillchen
Copy link
Contributor

@salman-neslit sorry I should have been more specific here, it should not be duplicated cc: @masvelio

Actions ---- (divider) Favs ---- (divider) All - Minus Favs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inter-Community navigation
4 participants