Mkaleem.neslit.10140.email digest #10338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rotorsoft
reviewed
Dec 18, 2024
| }), | ||
| output: z.object({ | ||
| threads: z.array(EnrichedThread), | ||
| numberOfThreads: z.number(), |
There was a problem hiding this comment.
numberOfThreads seems redundant if same as the length of the threads array
There was a problem hiding this comment.
we need this to add condition in knock . i did not find way to check array length there
Rotorsoft
reviewed
Dec 18, 2024
Rotorsoft
approved these changes
Dec 18, 2024
mzparacha
reviewed
Dec 23, 2024
| const sevenDaysAgo = new Date(); | ||
| sevenDaysAgo.setDate(new Date().getDate() - 7); | ||
| body: async ({ payload }) => { | ||
| // TODO User payload for unSubscribe once Recap email pr merge |
There was a problem hiding this comment.
is this still a todo? If not plz implement this or create a ticket to followup
mzparacha
reviewed
Dec 23, 2024
| return { | ||
| threads: threads, | ||
| numberOfThreads: threads.length, | ||
| // unsubscribe_link: TODO : will add once email recap PR got merged |
mzparacha
reviewed
Dec 23, 2024
| @@ -17,4 +17,13 @@ export const TriggerNotificationsWorkflow = { | |||
| }), | |||
| }; | |||
|
|
|||
| export const enableEmailDigest = { | |||
| input: z.object({ | |||
| communityId: z.string(), | |||
There was a problem hiding this comment.
community_id, plz use snake case as per api convention
mzparacha
reviewed
Dec 23, 2024
| }), | ||
| output: z.object({ | ||
| threads: z.array(EnrichedThread), | ||
| numberOfThreads: z.number(), |
There was a problem hiding this comment.
snake_case as per api convention
mzparacha
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #10140
Description of Changes
For some reason, Liquid doesn't seem to evaluate the variable properly when used with the square bracket notation (communities[name]). Instead, it seems to look for a key literally named test, not the value inside the variable.
the same code work in different Liquid base editor face the issue with "Knock eidtior"
"How We Fixed It"
For some reason, Liquid doesn't seem to evaluate the variable properly when used with the square bracket notation (communities[name]). Instead, it seems to look for a key literally named test, not the value inside the variable.
the same code work in different Liquid base editor face the issue with "Knock eidtior"