Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referral events processing #10344

Merged
merged 19 commits into from
Dec 20, 2024
Merged

Add referral events processing #10344

merged 19 commits into from
Dec 20, 2024

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Dec 17, 2024

Link to Issue

Closes: #9999

Description of Changes

  • Removed referral_link and all it's references -> replaced with just the referrer_address
  • Added chain-event processing for ReferralSet and FeeDistributed

Test Plan

Deployment Plan

Other Considerations

@timolegros timolegros marked this pull request as ready for review December 19, 2024 22:51
Copy link
Contributor

@Rotorsoft Rotorsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!... lots of refactoring of new code 😆

@timolegros
Copy link
Collaborator Author

nice!... lots of refactoring of new code 😆

Unfortunately yeah - I think it would be wise for future projects to take a "protocol first" approach. That is, we integrate the protocol on the platform side before we do anything else. It may help avoid such refactors in the future.

# Conflicts:
#	packages/commonwealth/client/scripts/views/modals/InviteLinkModal/useReferralLink.ts
@timolegros timolegros merged commit 1c931b6 into master Dec 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🟪 Referral Manager
3 participants