Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add community icon url to notification schemas #10358

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Link to Issues:
Closes #10279
Closes #10264

Link to Devin run: https://app.devin.ai/sessions/67c12233d60c4926960e84c8d427ce7e

Description of Changes:

  • Adds community_icon_url field to CommentCreatedNotification schema
  • Adds community_icon_url field to UserMentionedNotification schema
  • Leverages existing enriched notification schema structure from email.schemas.ts
  • No changes to configuration environments or custom notification cell
  • No changes to community_url fields

Test Plan:

  • Verify notification schema changes compile successfully
  • Verify enriched notifications include community icon URL when available
  • Verify notifications work correctly with and without community icon URLs
  • Verify no breaking changes to existing notification functionality

Deployment Plan:
N/A - Schema changes only

Other Considerations:

  • No configuration environment changes included
  • No custom notification cell changes included
  • No community_url changes included

- Add community_icon_url to CommentCreatedNotification schema
- Add community_icon_url to UserMentionedNotification schema
- Leverage existing enriched notification schema structure

Closes #10279
Closes #10264

Co-Authored-By: Dillon Chen <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

@github-actions github-actions bot marked this pull request as draft December 17, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

we need to add user_avatar in push notification User profile avatar should be seen in notifications
0 participants