Improving sidebar navigation on a scoped page #10361
Open
+27
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into salman/issue#7988/improving-sidebar-navigation-on-ascope-page
…/github.com/hicommonwealth/commonwealth into salman/issue#7988/improving-sidebar-navigation-on-ascope-page
… into salman/issue#7988/improving-sidebar-navigation-on-ascope-page
masvelio
approved these changes
Jan 10, 2025
packages/commonwealth/client/scripts/views/components/sidebar/sidebar_section.tsx
Outdated
Show resolved
Hide resolved
masvelio
reviewed
Jan 10, 2025
packages/commonwealth/client/scripts/views/components/sidebar/discussion_section.tsx
Outdated
Show resolved
Hide resolved
mzparacha
reviewed
Jan 13, 2025
...s/commonwealth/client/scripts/views/components/sidebar/CommunitySection/CommunitySection.tsx
Show resolved
Hide resolved
mzparacha
reviewed
Jan 13, 2025
Comment on lines
+143
to
+145
| } else if (topic.weighted_voting) { | ||
| leftIcon = <CWIcon iconName="lockedNew" iconSize="small" />; | ||
| } else { |
There was a problem hiding this comment.
weighted voting and topic gating are 2 separate features. Checkout the logic in useTopicGating for using this icon for a gated topic.
mzparacha
reviewed
Jan 13, 2025
Comment on lines
+141
to
+148
| if (topicInvolvedInActiveContest) { | ||
| leftIcon = <CWIcon iconName="trophy" iconSize="small" />; | ||
| } else if (topic.weighted_voting) { | ||
| leftIcon = <CWIcon iconName="lockedNew" iconSize="small" />; | ||
| } else { | ||
| leftIcon = <CWIcon iconName="hash" iconSize="small" />; | ||
| } | ||
|
|
There was a problem hiding this comment.
i think the order of this block should be reversed, just so the icons are set in the precedence specified in PR description
Verify the topic icon conventions.
When a topic is created the default is the “#,”
When A topic is gated, it has a lock icon.
If the topic is in an active contest, it will have a trophy icon.
If a topic is gated AND active contest, the trophy icon is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #7988
Description of Changes
"How We Fixed It"
Test Plan
Deployment Plan
Other Considerations