fix: Various polishing fixes for AtomOne/Cosmos support #10414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timolegros
approved these changes
Dec 20, 2024
masvelio
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed it from display and action buttons
Tried adding pagination fetching via the proxy LCD but could not get it to work so switched to the RPC version for AtomOne. Now fetches all votes
fixed vote tallying for AtomOne
Hardcoded 66.7% passing support for AtomOne instead of 50% (this should be fetched from params for all cosmos chains but will do for now)
fixed deposit param fetching for AtomOne
fixed proposer display for AtomOne