Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads semantics #5648

Merged
merged 29 commits into from
Jan 5, 2024
Merged

Threads semantics #5648

merged 29 commits into from
Jan 5, 2024

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Nov 8, 2023

Link to Issue

Closes: #5340

Description of Changes

  • Updated Threads.chain to Threads.community_id
  • Removed unused offchain_threads_updated_at index on Threads.updated_at
  • Removed offchain prefixes from all indexes/fkeys/pkeys

Test Plan

  • Search for comments and threads
  • Delete a community
  • View community stats from the community analytics page
  • View related communities page
  • CRUD threads
  • CRUD polls
  • CRUD topics
  • Discord bot thread/comment CRUD
  • Export member list from admin panel
  • Fetch community stats from admin panel
  • CRUD thread subscriptions
  • View user dashboards
  • View another users profile
  • View and update your own profile

Deployment Plan

  1. Deploy to CW
  2. Deploy to Discobot

Other Considerations

Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left two small comments, besides, lgtm

# Conflicts:
#	packages/commonwealth/client/scripts/hooks/useSearchResults.ts
#	packages/commonwealth/client/scripts/state/api/threads/searchThreads.ts
#	packages/commonwealth/client/scripts/views/components/NewThreadForm/helpers/useNewThreadForm.ts
#	packages/commonwealth/client/scripts/views/components/Profile/ProfileActivityRow.tsx
#	packages/commonwealth/client/scripts/views/components/component_kit/new_designs/CWSearchBar/SearchBarDropdown.tsx
#	packages/commonwealth/client/scripts/views/components/thread_selector/thread_selector.tsx
#	packages/commonwealth/client/scripts/views/pages/create_community/erc20_form.tsx
#	packages/commonwealth/client/scripts/views/pages/create_community/erc721_form.tsx
#	packages/commonwealth/client/scripts/views/pages/create_community/polygon_form.tsx
#	packages/commonwealth/client/scripts/views/pages/notification_settings/index.tsx
#	packages/commonwealth/client/scripts/views/pages/view_thread/linked_proposals_card.tsx
#	packages/commonwealth/server/controllers/server_comments_methods/search_comments.ts
#	packages/commonwealth/server/controllers/server_threads_methods/delete_thread.ts
#	packages/commonwealth/server/controllers/server_threads_methods/get_bulk_threads.ts
#	packages/commonwealth/server/controllers/server_threads_methods/search_threads.ts
#	packages/commonwealth/server/routes/bulkOffchain.ts
#	packages/commonwealth/server/routes/linking/addThreadLinks.ts
#	packages/commonwealth/server/routes/status.ts
#	packages/commonwealth/server/scripts/emitWebhook.ts
#	packages/commonwealth/test/integration/api/external/getThreads.spec.ts
#	packages/commonwealth/test/integration/emitNotifications.spec.ts
#	packages/commonwealth/test/unit/server_controllers/server_comments_controller.spec.ts
#	packages/commonwealth/test/unit/server_controllers/server_threads_controller.spec.ts
# Conflicts:
#	packages/commonwealth/test/util/modelUtils.ts
@timolegros timolegros temporarily deployed to discobot-listener-staging December 28, 2023 11:50 Inactive
@timolegros timolegros marked this pull request as ready for review December 28, 2023 14:12
@timolegros timolegros requested a review from rbennettcw January 3, 2024 23:57
# Conflicts:
#	packages/commonwealth/server/controllers/server_communities_methods/get_community_stats.ts
#	packages/commonwealth/server/controllers/server_threads_methods/update_thread.ts
#	packages/commonwealth/server/routes/adminAnalytics.ts
#	packages/commonwealth/server/routes/deleteChain.ts
# Conflicts:
#	packages/commonwealth/server/util/activityQuery.ts
Copy link
Contributor

@lzach83 lzach83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# Conflicts:
#	packages/commonwealth/test/integration/api/createChain.spec.ts
@timolegros timolegros merged commit b922412 into master Jan 5, 2024
6 of 7 checks passed
@timolegros timolegros deleted the tim/threads-semantics branch January 5, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threads table + model semantics - Child of #3779
3 participants