-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple discobot from commonwealth #6203
Conversation
…/hicommonwealth/commonwealth into rotorsoft/6196.decouple-discobot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While cleaning up the tsconfig and restructuring is good I don't think removing the model attributes import is worth it here. We've had bugs introduced because these queries weren't properly typed.
Seems like this change should go in when models are moved to /libs
. I think this goes for any package that uses commonwealth
models. We shouldn't have to loosen types to decouple packages.
I agree, this is part of the tradeoffs when breaking this into small pieces, there are some chicken-egg scenarios we'll have to resolve temporarily. This will be resolved here: #6206 |
@timolegros can you approve this one to merge it? |
Removes all references to commonwealth service
Link to Issue
Closes: #6196
Description of Changes
"How We Fixed It"