-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move chain util to libs #6217
Move chain util to libs #6217
Conversation
We can test EVM/ETH side by viewing communities that have associated contracts like @kurtisassad could you check this to make sure there are no changes to the Webpack bundle size (i.e. tree shaking isn't affected)? Not sure if that's a possible issue here but since we are importing some of these files on the client and we are moving a significant number of files I want to make sure. |
@timolegros who can help me walk through these? |
Eth side:
Cosmos side:
I will run through both of these myself to review anyways so we can just hop in huddle when I do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless the high surface area (346 files changed) here, this is looking fine to merge.
Having said that, do we need this in 0.9.0? @Rotorsoft @ilijabojanovic My preference would be for Mark to take another review pass on the Cosmos side of things to make sure nothing is missed.
@timolegros and I just tested cosmos on frick and everything looked fine |
Well if the tests pass and we are confident in our coverage, Mark can pro forma sign off when he's back on Monday (and we'll plan on shipping in 0.9.0) |
Starts moving utilities from common-common to libs, in this case chain related code under
eth
andcosmos-ts
Link to Issue
Closes: #6208
Description of Changes
@hicommonwealth/chains
libs/chains/src/index.ts
is the public interface exporting types and utilsTest Plan