Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5972 - Removing the Community Tag from the Search Tag Results in Global Search #6218

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

Miaplacidus
Copy link
Contributor

The work in this PR makes it such that when a user is on any of a community's pages, removing the community tag from the search bar makes the search results global.

Currently, if you are on a community's page, regardless of whether the community tag is there, the search results are limited to the current community.

Link to Issue

Closes: #5972

Description of Changes

  • Removing the tag from the search bar when on a community page gives global search results

Test Plan

  • navigate to any community's page
  • enter a common search term in the search bar when the community tag is present.
  • remove the community tag and enter the same search term. You should see results from multiple communities.

Copy link
Contributor

@lzach83 lzach83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CowMuon CowMuon self-requested a review January 9, 2024 17:47
Copy link
Contributor

@CowMuon CowMuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Miaplacidus Miaplacidus merged commit 5bdf9fb into master Jan 9, 2024
7 checks passed
@Miaplacidus Miaplacidus deleted the 5972.ifu.global-search-on-remove-community-tag branch January 9, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing the community tag from the search bar should result in a global search
3 participants