-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactions model semantics #6219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/commonwealth/server/routes/deleteChain.ts # packages/commonwealth/server/scripts/emitWebhook.ts
timolegros
requested review from
rbennettcw,
lzach83,
kurtisassad and
Rotorsoft
January 8, 2024 23:33
Rotorsoft
approved these changes
Jan 9, 2024
# Conflicts: # packages/commonwealth/server/controllers/server_reactions_methods/delete_reaction.ts # packages/commonwealth/server/models/reaction.ts
jnaviask
reviewed
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Qs but overall LGTM
packages/commonwealth/server/migrations/20240104232957-reaction-community-semantics.js
Show resolved
Hide resolved
jnaviask
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #5341
Description of Changes
offchain
prefix from indexes + removes unused indexReactions.chain
toReactions.community_id
in DB, sequelize model, and client model (and refactor references)Test Plan
Deployment Plan
Other Considerations