Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions model semantics #6219

Merged
merged 14 commits into from
Jan 10, 2024
Merged

Reactions model semantics #6219

merged 14 commits into from
Jan 10, 2024

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Jan 5, 2024

Link to Issue

Closes: #5341

Description of Changes

  • Removes offchain prefix from indexes + removes unused index
  • Rename Reactions.chain to Reactions.community_id in DB, sequelize model, and client model (and refactor references)

Test Plan

  • Get community stats on analytics page and in admin panel
  • CRUD reactions on threads + comments (ensure counts are correct after creation/deletion)
  • Delete a community
  • Export members list from admin panel

Deployment Plan

Other Considerations

@timolegros timolegros changed the title Tim/reactions model semantics Reactions model semantics Jan 5, 2024
# Conflicts:
#	packages/commonwealth/server/routes/deleteChain.ts
#	packages/commonwealth/server/scripts/emitWebhook.ts
@timolegros timolegros temporarily deployed to commonwealth-frack January 8, 2024 20:13 Inactive
@timolegros timolegros marked this pull request as ready for review January 8, 2024 23:33
# Conflicts:
#	packages/commonwealth/server/controllers/server_reactions_methods/delete_reaction.ts
#	packages/commonwealth/server/models/reaction.ts
Copy link
Collaborator

@jnaviask jnaviask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Qs but overall LGTM

@timolegros timolegros merged commit 9eac281 into master Jan 10, 2024
7 checks passed
@timolegros timolegros deleted the tim/reactions-model-semantics branch January 10, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactions table + model semantics - Child of #3779
3 participants