#6513 - Update Editor Component UI - Toolbar Text Indenting

[Miaplacidus]

This PR adds buttons to the editor toolbar that allow the user to input left-aligned, center-aligned, right-aligned, and justified text.

Link to Issue

Closes: #6513

Description of Changes

• add buttons for text aligned to the left, center, right, and for justified text

Test Plan

• go to the create thread page
• enter and select text. When you click on one of the text alignment buttons, your selected text will be wrapped in a styled div
• without selecting text, click on one of the text alignment buttons. A styled div will appear in the editor.

[masvelio]

I am pretty confused how this supposed to work.

1. new icons have blue border on focus - should not have one, similar to other icons
   

2. a - I don't think we should insert html into the editor, it does not look good and user can delete it as they might not know why this is for
   b -when I don't have text selected and click one of the icon, cursor is at the end, instead in the middle of html tag (but considering previous point, we probably should not have html tags at all in the editor)

Kapture.2024-02-07.at.12.18.19.mp4

[Miaplacidus]

@masvelio
Cursor placement is left to other cards.
In addition, there is no way to align text in markdown alone. HTML in markdown is allowed and pretty common. The only way to achieve text alignment is to add HTML.

@zakhap @CowMuon @jessmart1213

[Miaplacidus]

@masvelio
The blue outline on focus appears to be default Quill styling on all of the buttons. I've gone ahead and removed it.

[jnaviask]

@Miaplacidus we should NOT support HTML in Markdown, for the time being. Reason is that it poses a major security risk, as it would allow me to inject arbitrary scripts into the page if I set up the correct payload. We may want to support it later once we have validation logic in place, but we thus far have no mandate from product to support any HTML features.

[lzach83]

@Miaplacidus we should NOT support HTML in Markdown, for the time being. Reason is that it poses a major security risk, as it would allow me to inject arbitrary scripts into the page if I set up the correct payload. We may want to support it later once we have validation logic in place, but we thus far have no mandate from product to support any HTML features.

@jnaviask Wasn't aware of this... in #5940, PR: #6375

The pasting from HackMD issues we're mainly surrounding the tables which are in that html format. This may not be directly related, however; since I completely reconstruct the pasted markdown html in my PR. But would be helpful to get 👀 on that one from you as well.

[Miaplacidus]

@jnaviask
Does that mean we just close this ticket? Markdown does not have text alignment without html.

[jnaviask]

@Miaplacidus we should raise the Q with product to get a clear answer.

[jnaviask]

@lzach83 I don't think your PR involves inserting HTML directly into the editor -- it's fine for some markdown patterns to generate HTML on our side, but what we don't want is user-submitted HTML.

[zakhap]

Affirmative here. If general text-alignment requires user-inserted HTLM, we should avoid that at this time.

ONE Caveat here is TABLE Alignment where there is a standard pattern of including : colons in the table header rows. This does not need to have specific buttons in the editor for helping the user, it can be a IYKYK situation (we should support the syntax).

[Miaplacidus]

@zakhap @jnaviask @lzach83
Understood! I'll close this PR. If we ever decide to implement HTML support, we can come back to this.

[CowMuon]

This can be closed, per Product, but please do see Zak's caveat on nekudatayim handling.