Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch to handle v1 chains that return nextKey as string #6611

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

mhagel
Copy link
Contributor

@mhagel mhagel commented Feb 6, 2024

Link to Issue

Closes: #6609

Description of Changes

  • makes sure paginated proposal types load properly for UX (a gov v1 chain)

"How We Fixed It"

  • If pagination.next_key is a string, this converts it to the expected uint8array

Test Plan

Deployment Plan

Other Considerations

@timolegros
Copy link
Collaborator

Hey, just noting that this may need to be updated for the cosmos notification generator as well as I believe it uses the same or similar logic.

@mhagel mhagel requested a review from timolegros February 7, 2024 00:18
@mhagel mhagel marked this pull request as ready for review February 7, 2024 00:18
@mhagel
Copy link
Contributor Author

mhagel commented Feb 7, 2024

Hey, just noting that this may need to be updated for the cosmos notification generator as well as I believe it uses the same or similar logic.

thanks. done.

same patch for cosmosGovNotifications
@mhagel mhagel force-pushed the mark.6609-v1-paginated-proposals branch from 59f61ee to 3da549b Compare February 7, 2024 17:32
Copy link
Contributor

@ianrowan ianrowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnaviask jnaviask merged commit d38a433 into master Feb 7, 2024
5 of 7 checks passed
@jnaviask jnaviask deleted the mark.6609-v1-paginated-proposals branch February 7, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all v1 proposals load (UX)
4 participants