Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6723-New Thread Markdown broke #6724

Merged
merged 1 commit into from
Feb 14, 2024
Merged

6723-New Thread Markdown broke #6724

merged 1 commit into from
Feb 14, 2024

Conversation

lzach83
Copy link
Contributor

@lzach83 lzach83 commented Feb 13, 2024

Link to Issue

Closes: #6723

Description of Changes

  • Simplified the useNotionPaste hook

"How We Fixed It"

  • By removing the check and the manual manipulation of the Quill Delta
  • Was doing too much and causes a check for the delta before it was populated

Test Plan

  1. Goto create thread
  2. Paste the following:
  3. Copy this content
An h1 header
============

Paragraphs are separated by a blank line.

2nd paragraph. *Italic*, **bold**, and `monospace`. Itemized lists
look like:

  * this one
  * that one
  * the other one

Note that --- not considering the asterisk --- the actual text
content starts at 4-columns in.

> Block quotes are
> written like so.
>
> They can span multiple paragraphs,
> if you like.

Use 3 dashes for an em-dash. Use 2 dashes for ranges (ex., "it's all
in chapters 12--14"). Three dots ... will be converted to an ellipsis.
Unicode is supported. ☺
  1. Paste this with keyboard (ctrl + v or cmd + v)
  2. To ensure no regression do the same with the following Notion MD:
- [x]  Click anywhere and just start typing
- [ ]  Hit **/** to see all the types of content you can create - headers, videos, sub pages, etc.
- [ ]  Highlight any text, and use the menu that pops up to **style** *your* ~~writing~~ `however` [you](https://www.notion.so/product) like
- [ ]  See the **⋮⋮** to the left of this checkbox on hover? Click and drag to move this line
- [ ]  Explore the sidebar to your left

Copy link
Collaborator

@Israellund Israellund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jnaviask
Copy link
Collaborator

Should go into 0.9.5.

Copy link
Contributor

@CowMuon CowMuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy Cow, it does seem to do the thing!

@lzach83 lzach83 merged commit abbc728 into master Feb 14, 2024
7 of 8 checks passed
@lzach83 lzach83 deleted the 6723-markdownIntoNewThread branch February 14, 2024 01:18
ilijabojanovic pushed a commit that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paste of markdown content into new thread does not work
4 participants