Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6733- Fixed changing topic bug #6737

Merged
merged 1 commit into from
Feb 14, 2024
Merged

6733- Fixed changing topic bug #6737

merged 1 commit into from
Feb 14, 2024

Conversation

lzach83
Copy link
Contributor

@lzach83 lzach83 commented Feb 14, 2024

Link to Issue

Closes: #6733

Description of Changes

  • Fixes overflow css that was causing the dropdown to not work

"How We Fixed It"

  • Added the inherit property to css rather than auto which caused the regression

Test Plan

  • Go to any thread
  • Attempt to change topic
  • Ensure you can change topic

@lzach83 lzach83 self-assigned this Feb 14, 2024
@CowMuon CowMuon self-requested a review February 14, 2024 18:57
CowMuon
CowMuon approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@CowMuon CowMuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnaviask jnaviask merged commit ffe98e2 into master Feb 14, 2024
7 of 8 checks passed
@jnaviask jnaviask deleted the 6733-changingTopic branch February 14, 2024 19:03
jnaviask pushed a commit that referenced this pull request Feb 14, 2024
@lzach83 @jnaviask
Fixed overflow issue (#6737)
8b6f139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CowMuon CowMuon CowMuon approved these changes

@jnaviask jnaviask jnaviask approved these changes

@Miaplacidus Miaplacidus Awaiting requested review from Miaplacidus

@ilijabojanovic ilijabojanovic Awaiting requested review from ilijabojanovic

@masvelio masvelio Awaiting requested review from masvelio

@mzparacha mzparacha Awaiting requested review from mzparacha

@Israellund Israellund Awaiting requested review from Israellund

@rbennettcw rbennettcw Awaiting requested review from rbennettcw

Assignees

@lzach83 lzach83

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User can't change thread topic
3 participants
@lzach83 @jnaviask @CowMuon