Bump prettier to 3.3.3 and eslint-plugin-prettier to 5.2.1

[rjwebb]

We're using the satisfies keyword in #8537. The current version of Prettier that we are using (2.7.1) does not support this - support was added in version 2.8.1. I also had to upgrade eslint-plugin-prettier since version 4.x is incompatible with prettier 3.x.

[jnaviask]

@rjwebb please merge your branch against master so we can get CI passing and merge this PR

[jnaviask]

Must have ETH_ALCHEMY_API_KEY env var set in packages/commonwealth/.env to migrate

Interesting, I wonder if having the PR coming in from another repo is causing trouble here. Also not sure what the unit test issue is...

[rjwebb]

Yep I think that's the reason. PRs from external repos cannot access the source repo's secrets, otherwise an untrustworthy outsider like me could write a malicious pull request that exfiltrates the secret. So in this case the template value ${{ secrets.ETH_ALCHEMY_API_KEY }} in .github/workflows/CI.yml is not provided which then causes the migration test to fail.

https://stackoverflow.com/a/76975532

https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

[jnaviask]

@rjwebb do you have permission to push a branch to our repo and re-point your PR that way? If not, I can do it, or I can add you.

[rjwebb]

Looks like I still have permission, I've created a PR here #8861