Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate Bans table. #8994

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Eliminate Bans table. #8994

merged 4 commits into from
Aug 26, 2024

Conversation

jnaviask
Copy link
Collaborator

Link to Issue

Closes: #8990

Description of Changes

  • Eliminates redundant "Bans" table by moving field to Address is_banned boolean.
  • Wrote reversible migration to transfer data.
  • Deleted unused getBannedAddresses route.

Test Plan

  • Make yourself admin, ban an address (note that there is currently no way to unban an address in the UI or platform). Ideally pick an address you control, but that isn't linked to your admin user.
  • Switch to the banned address. Confirm error on attempting to interact with forum.

@jnaviask jnaviask self-assigned this Aug 26, 2024
Rotorsoft
Rotorsoft approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@Rotorsoft Rotorsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - removal of ban cache in all controllers and tests will be part of #8930

@jnaviask jnaviask merged commit 4dd9ad6 into master Aug 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@Rotorsoft Rotorsoft Rotorsoft approved these changes

@ilijabojanovic ilijabojanovic Awaiting requested review from ilijabojanovic

@kurtisassad kurtisassad Awaiting requested review from kurtisassad

@timolegros timolegros Awaiting requested review from timolegros

Assignees

@jnaviask jnaviask

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate "Bans" table
3 participants
@jnaviask @Rotorsoft @rbennettcw