-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge this branch to help fix build issues. #9022
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@burtonator both errors in Lets:
|
burtonator
changed the title
I need help fixing this branch :)
Merge this branch to help fix build issues.
Sep 4, 2024
timolegros
requested changes
Sep 5, 2024
packages/commonwealth/server/controllers/server_communities_methods/update_community_id.ts
Outdated
Show resolved
Hide resolved
packages/commonwealth/server/controllers/server_communities_methods/delete_community.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/commonwealth/server/controllers/server_threads_methods/create_thread_comment.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not fix a specific ticket.... it's like 80% of what we need to fix the ticket and then I have to go back and verify it's 100% completed. See the comments from @timolegros below.
OK. Here's the deal.
I found a bug with the way we're migrating to strict null checks that was hiding 19 compilation errors.
I have a PR here:
#9021
which identifies them.
I was able to fix like five.
I've removed the @ts-expect-error from the files that need to be repaired so this build will have like 10-20 compilation errors.
We just have to fix these... then we're good to go.