Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge this branch to help fix build issues. #9022

Closed
wants to merge 8 commits into from

Conversation

burtonator
Copy link
Collaborator

@burtonator burtonator commented Aug 27, 2024

This does not fix a specific ticket.... it's like 80% of what we need to fix the ticket and then I have to go back and verify it's 100% completed. See the comments from @timolegros below.

OK. Here's the deal.

I found a bug with the way we're migrating to strict null checks that was hiding 19 compilation errors.

I have a PR here:

#9021

which identifies them.

I was able to fix like five.

I've removed the @ts-expect-error from the files that need to be repaired so this build will have like 10-20 compilation errors.

We just have to fix these... then we're good to go.

@timolegros
Copy link
Collaborator

timolegros commented Aug 30, 2024

@burtonator both errors in delete_community.ts and both errors in update_community_id.ts should be resolved in #9068. A couple of other ones related to notifications have also been resolved on master since the recent notification removal PRs. We will only be left with a handful.

Lets:

  1. Merge Remove all legacy notification/subscription models #9068 and Random compilation fixes.  #9020
  2. Review remaining errors and create tickets + assign appropriately otherwise this PR will forever remain in an "I thought he was handling that error" situation.

@burtonator burtonator changed the title I need help fixing this branch :) Merge this branch to help fix build issues. Sep 4, 2024
@burtonator burtonator marked this pull request as ready for review September 4, 2024 19:26
# Conflicts:
#	packages/commonwealth/server/controllers/server_threads_methods/create_thread_comment.ts
@timolegros timolegros marked this pull request as draft December 18, 2024 15:13
@burtonator burtonator closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants