-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app.chain.meta
and related types to ExtendedCommunity
trpc response type + Removed ChainInfo
type
#9035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzparacha
changed the title
Update
Update Aug 28, 2024
app.chain.meta
and related types to ExtendedCommunity
trpc…app.chain.meta
and related types to ExtendedCommunity
trpc response type
mzparacha
changed the title
Update
Update Aug 28, 2024
app.chain.meta
and related types to ExtendedCommunity
trpc response typeapp.chain.meta
and related types to ExtendedCommunity
trpc response type + Removed ChainInfo
type
mzparacha
requested review from
masvelio,
Israellund,
burtonator and
jnaviask
and removed request for
masvelio
August 28, 2024 17:27
masvelio
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clicked around, didnt encounter any issues. Code lgtm.
let's try to merg this in as it touches a lot of files |
Israellund
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #8811
Description of Changes
Update
app.chain.meta
and related types toExtendedCommunity
trpc response type + Removed ChainInfo type"How We Fixed It"
N/A
Test Plan
Deployment Plan
N/A
Other Considerations
N/A