Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app.chain.meta and related types to ExtendedCommunity trpc response type + Removed ChainInfo type #9035

Merged
merged 10 commits into from
Sep 10, 2024

Conversation

mzparacha
Copy link
Contributor

@mzparacha mzparacha commented Aug 28, 2024

Link to Issue

Closes: #8811

Description of Changes

Update app.chain.meta and related types to ExtendedCommunity trpc response type + Removed ChainInfo type

"How We Fixed It"

N/A

Test Plan

  • No community related future should regress.

Deployment Plan

N/A

Other Considerations

N/A

@github-actions github-actions bot marked this pull request as draft August 28, 2024 17:24
@mzparacha mzparacha changed the title Update app.chain.meta and related types to ExtendedCommunity trpc… Update app.chain.meta and related types to ExtendedCommunity trpc response type Aug 28, 2024
@mzparacha mzparacha changed the title Update app.chain.meta and related types to ExtendedCommunity trpc response type Update app.chain.meta and related types to ExtendedCommunity trpc response type + Removed ChainInfo type Aug 28, 2024
@mzparacha mzparacha self-assigned this Aug 28, 2024
@mzparacha mzparacha marked this pull request as ready for review August 28, 2024 17:27
@mzparacha mzparacha requested review from masvelio, Israellund, burtonator and jnaviask and removed request for masvelio August 28, 2024 17:27
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clicked around, didnt encounter any issues. Code lgtm.

@masvelio
Copy link
Contributor

masvelio commented Sep 3, 2024

let's try to merg this in as it touches a lot of files

@mzparacha mzparacha merged commit eb26db5 into master Sep 10, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Post #8779] - Deprecate ChainInfo.ts
3 participants