Subscription preference sync with Knock (Enable Push Notif) #9080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timolegros
added
the
deployment plan
kurtisassad
reviewed
Sep 5, 2024
kurtisassad
approved these changes
Sep 5, 2024
Rotorsoft
approved these changes
Sep 6, 2024
Rotorsoft
approved these changes
Sep 6, 2024
# Conflicts: # libs/adapters/src/rabbitmq/configuration/rascalConfig.ts # libs/adapters/src/rabbitmq/types.ts # libs/model/src/models/index.ts # packages/commonwealth/server/workers/knock/notificationsPolicy.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9049
Description of Changes
Test Plan
Nothing for now. This feature will not be enabled until the push notifications UI is complete at which point we will test end to end.
Deployment Plan
SubscriptionPreferencesUpdatedis not included in theALLOWED_EVENTSenv varSEND_EMAILSenv var tofalseOther Considerations