Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed duplicate trending communities #9084

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

mzparacha
Copy link
Contributor

Link to Issue

Closes: #9081

Description of Changes

Fixed duplicate trending communities

"How We Fixed It"

If a user has multiple addresses joined to a community, the trending community query utilizes each of those addresses/communities to find trending communities for that specific user. We updated the query to use unique community ids/addresses in finding trending communities for that user.

Test Plan

  • Login
  • Join a community with multiple addresses
  • Visit the dashboard page
  • Verify you don't see duplicate trending communities

Deployment Plan

N/A

Other Considerations

N/A

Copy link
Collaborator

@ilijabojanovic ilijabojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnaviask jnaviask merged commit 95787ac into master Aug 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: User dashboard shows duplicate trending communities option + feeds from for you and global are the same
3 participants