Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors tRPC middleware #9104

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Refactors tRPC middleware #9104

merged 6 commits into from
Sep 4, 2024

Conversation

Rotorsoft
Copy link
Contributor

@Rotorsoft Rotorsoft commented Sep 3, 2024 •
edited
Loading

Link to Issue

Closes: #9094

Description of Changes

  • Moves middleware to tRPC framework level
  • Improves encapsulation and simplifies interfaces
  • Adds traces to in-memory adapters to improve local debugging
  • Use in-memory adapters when not in production APP

Blocked by #9091

Test Plan

  • Create a community and threads
  • Observe traces to validate that stats and analytics helpers are properly invoked

rbennettcw
rbennettcw approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@rbennettcw rbennettcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see tracking get added to the framework!

packages/commonwealth/server.ts Outdated Show resolved Hide resolved
timolegros
timolegros requested changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@timolegros timolegros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one small issue regarding adapter init.

packages/commonwealth/server.ts Outdated Show resolved Hide resolved
packages/commonwealth/server.ts Outdated Show resolved Hide resolved
@Rotorsoft Rotorsoft merged commit ab4b992 into master Sep 4, 2024
9 checks passed
@Rotorsoft Rotorsoft mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@timolegros timolegros timolegros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Measure command/query latency in batch tRPC requests
3 participants
@Rotorsoft @timolegros @rbennettcw