Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CommunityAlert dates to strings #9116

Merged
merged 4 commits into from
Sep 7, 2024
Merged

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Sep 4, 2024

Link to Issue

Closes: #9016

Description of Changes

Test Plan

  • CRUD community alert subscriptions in the notification settings

Deployment Plan

Other Considerations

Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, so this is the pattern we should follow from now on? Should we refactor other places in the app using this approach?

@timolegros
Copy link
Collaborator Author

nice, so this is the pattern we should follow from now on? Should we refactor other places in the app using this approach?

Yes, we can gradually transition models to use strings instead of dates but this was a very simple/specific case. Other models may extensively utilize Sequelize converted dates (e.g. Thread) so doing this may prove inefficient. We will need to do this on a case-by-case basis.

@timolegros timolegros merged commit cbf410c into master Sep 7, 2024
9 checks passed
@timolegros timolegros deleted the tim/CA-date-strings branch September 7, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert CommunityAlerts dates to strings
3 participants