Simplified /writeUserSettings params #9124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzparacha
force-pushed
the
malik.8393.cleanup.writeUserSetting
branch
from
1a04d8b to
4998787
Compare
timolegros
reviewed
Sep 5, 2024
| !( | ||
| typeof disable_rich_text !== 'boolean' || | ||
| typeof promotional_emails_enabled !== 'boolean' || | ||
| email_notification_interval |
There was a problem hiding this comment.
This logic seems incorrect. If disable_rich_text !== 'boolean' is true then the conditional evaluates to false and an InvalidSetting error is not returned.
| return next(new AppError(Errors.InvalidSetting)); | ||
| } | ||
|
|
||
| return res.json({ status: 'Success', result: { key, value } }); | ||
| if (typeof disable_rich_text === 'boolean') { |
There was a problem hiding this comment.
This stuff should be validated ahead of time and an error thrown earlier if the type is incorrect. If the conditionals are set up correct then Typescript should be able to automatically narrow down the type to Boolean.
|
@mzparacha let's try to cleanup the PR list. This one is pretty old, I guess it might be closed? Or let's plan how to proceed |
|
Thanks for the reminder @masvelio, i will try to update it by EOW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #8393
Description of Changes
Simplified /writeUserSettings params, replacing
key: string / value: stringparam pairs with proper param names"How We Fixed It"
N/A
Test Plan
Deployment Plan
N/A
Other Considerations
This PR doesn't aim to move the modified API to newer standards, its just about cleaning up the params which caused some confusion in an earlier PR.