Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors create thread reaction command #9127

Merged
merged 14 commits into from
Sep 6, 2024
Merged

Refactors create thread reaction command #9127

merged 14 commits into from
Sep 6, 2024

Conversation

Rotorsoft
Copy link
Contributor

@Rotorsoft Rotorsoft commented Sep 5, 2024 •
edited
Loading

Link to Issue

Closes: #8934

Description of Changes

  • See ticket

Test Plan

  • Upvoting on threads should work as expected

@Rotorsoft Rotorsoft marked this pull request as draft September 5, 2024 16:05
@Rotorsoft Rotorsoft marked this pull request as ready for review September 5, 2024 19:37
rbennettcw
rbennettcw approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@rbennettcw rbennettcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, seems to work

libs/model/src/services/stakeHelper.ts Show resolved Hide resolved
libs/model/src/thread/CreateThreadReaction.command.ts Show resolved Hide resolved
@Rotorsoft Rotorsoft merged commit 9907607 into master Sep 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@kurtisassad kurtisassad kurtisassad approved these changes

@timolegros timolegros Awaiting requested review from timolegros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🟦 CreateThreadReaction
3 participants
@Rotorsoft @kurtisassad @rbennettcw