Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fingerprint for trpc errors #9174

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Add fingerprint for trpc errors #9174

merged 3 commits into from
Sep 12, 2024

Conversation

timolegros
Copy link
Collaborator

Link to Issue

Closes: #9173

Description of Changes

  • Added a fingerprint to tRPC error logs which forces Rollbar to group errors by the fingerprint rather than it's internal algorithm.

Test Plan

  • Throw an error from any tRPC route and then trigger that route

Deployment Plan

Other Considerations

@timolegros timolegros merged commit 9e61a0a into master Sep 12, 2024
10 checks passed
@timolegros timolegros deleted the tim/fix-zod-error-fingerprint branch September 12, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rotorsoft Rotorsoft Rotorsoft approved these changes

@kurtisassad kurtisassad kurtisassad approved these changes

@rbennettcw rbennettcw Awaiting requested review from rbennettcw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Rollbar error grouping
3 participants
@timolegros @kurtisassad @Rotorsoft