Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread version box now smaller #9179

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Israellund
Copy link
Collaborator

Link to Issue

Closes: #9107

Description of Changes

  • makes the thread version box the same size as the other elements in the same line

"How We Fixed It"

-changed some minimal css

Test Plan

  • go to a discussion that has been edited at least twice or edited a discussion at least twice. There needs to be a dropdown menu to see the changes
  • click on the dropdown element so that it is highlighted, confirm that it is the same size as the boxes to the left and the right of it and that the highlighted area doesn't overlap any other element in the line.

@Israellund Israellund merged commit ecd63b1 into master Sep 11, 2024
11 checks passed
@Israellund Israellund deleted the israel.9107.thread-version-box-too-big branch September 11, 2024 20:20
@masvelio
Copy link
Contributor

@Israellund @mzparacha @burtonator we can't just simply change generic components because they affect many other places in the app.

image
image

image

@Israellund please revert it and change only the instance that needs to be modifed

@Israellund Israellund restored the israel.9107.thread-version-box-too-big branch September 12, 2024 20:41
@Israellund Israellund deleted the israel.9107.thread-version-box-too-big branch September 17, 2024 19:25
@Israellund
Copy link
Collaborator Author

this has been fixed here #9257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread version box too big
4 participants