Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove URI encoding #9180

Closed
wants to merge 27 commits into from
Closed

Remove URI encoding #9180

wants to merge 27 commits into from

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Sep 11, 2024 •
edited
Loading

Link to Issue

Closes: #9168
Closes: #9169
Starts but does not close: #9167

Description of Changes

  • Replaces body/text columns with the plaintext columns

Test Plan

  • Set yourself as super admin
  • View old threads/comments with varying formats (lists, code blocks, quotes, titles, etc)
  • Edit old threads/comments (add/remove varying formats)
  • Create new threads/comments and then edit them

Deployment Plan

Other Considerations

  • Cuts in half the amount of data sent to the client when fetching threads or comments. This may improve loading speeds for large threads or threads with lots of comments.

@timolegros
Copy link
Collaborator Author

This PR will remain in draft until #9170 is merged

@timolegros
Copy link
Collaborator Author

Wrong approach. The plaintext columns cannot accurately replace body or text. Superseded by #9186.

@timolegros timolegros closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@timolegros