Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sign in and create community flow #9187

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

ianrowan
Copy link
Contributor

@ianrowan ianrowan commented Sep 11, 2024

Link to Issue

Closes: #9185

Description of Changes

image

Test Plan

  • Attempt to create a community with stake
  • In community launch contests and visit with different chain selected in meta mask(follow Fixed unnecessary wallet connect popup for contests #9089 test plan to avoid regression
  • ensure no pop-ups
  • sign out, refresh browser and attempt to sign in with metamask

@ianrowan ianrowan linked an issue Sep 11, 2024 that may be closed by this pull request
@ianrowan ianrowan marked this pull request as ready for review September 11, 2024 15:28
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I run into this problem eventually, thanks for fixing this! It works well

@ianrowan ianrowan merged commit d90d964 into master Sep 11, 2024
11 checks passed
@ianrowan ianrowan deleted the 9185-community-stake-console-errors branch September 11, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community stake: Console errors
3 participants