Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERC20 Launchpad] - UI for Launch token step #9193

Merged
merged 9 commits into from
Sep 12, 2024

Conversation

mzparacha
Copy link
Contributor

Link to Issue

Closes: #8705

Description of Changes

  • Added UI for Launch token step of tokenized community creation flow

"How We Fixed It"

N/A

Test Plan

  • Enable FLAG_TOKENIZED_COMMUNITY
  • Visit /createTokenCommunity
  • Fill the form - verify the form validation works as expected
  • Submit
  • Verify you get redirected to step 2 "Community Information" with a "Not Implemented" label

Deployment Plan

N/A

Other Considerations

N/A

@mzparacha mzparacha self-assigned this Sep 11, 2024
@github-actions github-actions bot marked this pull request as draft September 11, 2024 21:50
@mzparacha mzparacha marked this pull request as ready for review September 11, 2024 21:50
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Adjust breadcrumb

image

  1. This button seems to be too hight vs design
    image

  2. There are validation requirements in the ticket that do not seem to work properly regarding token name, ticker, description . Will it be implemented further?
    image

  3. Mobile does not look good
    image

Some small comments but looks good to me. Let's fix it and g2g

@mzparacha
Copy link
Contributor Author

Thanks for the feedback @masvelio - re #9193 (review)

  1. I thought of adding custom breadcrumb support to fix this and a similar case in [ERC20 Launchpad] - UI for Launch token community step #9194. Created a ticket -> Add custom breadcrumbs support #9197
  2. Actually, I kept it intentionally - some more elements in the new designs didn't follow the existing design system like a Banner and some spacings, for consistency I kept the same styles as we have for normal community creation flow. - lmk if you think we could do something else here.
  3. I missed this, Fixed now.
  4. Fixed.

@mzparacha mzparacha merged commit 5dd73c8 into master Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch token + community flow - UI Integration
3 participants