Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed crash when topic is updated #9218

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fixed crash when topic is updated #9218

merged 1 commit into from
Sep 13, 2024

Conversation

masvelio
Copy link
Contributor

Link to Issue

Closes: #9217

Description of Changes

  • used optional chain operator to prevent crash

Test Plan

  • Create 2 topics that are not featured in the sidebar
  • Go to manage topics
  • Edit one of the topics and add it as featured in the sidebar
  • Edit the second topic to feature it in the sidebar
  • Page should work without crash

Deployment Plan

  1. n/a

Other Considerations

  • n/a

ilijabojanovic
ilijabojanovic approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@ilijabojanovic ilijabojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on PR

@ilijabojanovic ilijabojanovic merged commit c303c0f into master Sep 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Israellund Israellund Israellund approved these changes

@timolegros timolegros timolegros approved these changes

@mzparacha mzparacha mzparacha approved these changes

@ilijabojanovic ilijabojanovic ilijabojanovic approved these changes

@burtonator burtonator Awaiting requested review from burtonator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page break when updating 2nd topic
5 participants
@masvelio @ilijabojanovic @mzparacha @timolegros @Israellund