Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERC20 Launchpad] - Endpoint integration for Launch token step #9227

Merged

Conversation

mzparacha
Copy link
Contributor

Link to Issue

Closes: #9207

Description of Changes

Added endpoint integration for Launch token step

"How We Fixed It"

N/A

Test Plan

  • Enable FLAG_TOKENIZED_COMMUNITY
  • Visit /createTokenCommunity
  • Verify you see the auth modal popup with only EVM wallet options (if you are not logged in already)
  • Verify you see the address selection modal popup (if you are logged in)
  • If you close the auth modal or the address selection modal without authentication, then verify you get these modals when you try to submit.
  • Fill the form - verify the form validation works as expected
  • Submit - the form submission will fail with this error ATM (plz see "Other Considerations" for more info)
image

Deployment Plan

N/A

Other Considerations

  • ATM the form submission will throw an error like this, it will be fixed when we deploy the token specific abis (cc: @ianrowan)
image
  • There are some TODO's left intentionally in the code that relates to adding some token-specific information, these will be done in a followup.

@mzparacha mzparacha requested review from masvelio and ianrowan and removed request for masvelio September 16, 2024 13:52
@mzparacha mzparacha self-assigned this Sep 16, 2024
@github-actions github-actions bot marked this pull request as draft September 16, 2024 13:53
@mzparacha mzparacha marked this pull request as ready for review September 16, 2024 13:53
Copy link
Collaborator

@Israellund Israellund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but agree with Marcin's comments

@mzparacha mzparacha merged commit eb6e1da into master Sep 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch token + community flow - Endpoint Integration
3 participants