Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERC20 Launchpad] - Endpoint integration for Community information step #9230

Merged

Conversation

mzparacha
Copy link
Contributor

Link to Issue

Closes: #9208

Description of Changes

Added endpoint integration for Community information step

"How We Fixed It"

N/A

Test Plan

  • Enable FLAG_TOKENIZED_COMMUNITY
  • Visit /createTokenCommunity
  • Open /packages/commonwealth/client/scripts/views/pages/LaunchToken/useCreateCommunity.ts and add your currently logged-in Ethereum wallet address for the setSelectedAddress state - this is only temporary for testing - the actual address selection happens in step 1 of this flow
  • Verify the form is prefilled with data constructed from sample token information
  • Submit the form and verify that a new token community has been created.

Deployment Plan

N/A

Other Considerations

N/A

@github-actions github-actions bot marked this pull request as draft September 16, 2024 14:45
@mzparacha mzparacha marked this pull request as ready for review September 16, 2024 14:45
@mzparacha mzparacha requested review from masvelio, Israellund and burtonator and removed request for masvelio September 16, 2024 14:46
@mzparacha mzparacha self-assigned this Sep 16, 2024
@mzparacha mzparacha requested a review from masvelio September 16, 2024 14:46
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. image
    I remember we had some error displaying under the input for occupied community names 🤔

@mzparacha
Copy link
Contributor Author

Re: #9230 (review)

  1. Yes, that was removed during the de-coupling of communities config from the app state variable. Basically previously we had all community names in FE so validation was quicker but now we rely on the API to confirm that.

Copy link
Collaborator

@Israellund Israellund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mzparacha mzparacha merged commit c68d556 into master Sep 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community Details - Endpoint Integration
3 participants