-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ERC20 Launchpad] - Endpoint integration for Community information step #9230
Merged
mzparacha
merged 6 commits into
master
from
malik.9028.tokenized-community-step2-api-integration
Sep 24, 2024
Merged
[ERC20 Launchpad] - Endpoint integration for Community information step #9230
mzparacha
merged 6 commits into
master
from
malik.9028.tokenized-community-step2-api-integration
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzparacha
requested review from
masvelio,
Israellund and
burtonator
and removed request for
masvelio
September 16, 2024 14:46
masvelio
reviewed
Sep 17, 2024
.../scripts/views/pages/LaunchToken/steps/CommunityInformationStep/CommunityInformationStep.tsx
Show resolved
Hide resolved
masvelio
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.../scripts/views/pages/LaunchToken/steps/CommunityInformationStep/CommunityInformationStep.tsx
Outdated
Show resolved
Hide resolved
Re: #9230 (review)
|
Israellund
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9208
Description of Changes
Added endpoint integration for Community information step
"How We Fixed It"
N/A
Test Plan
FLAG_TOKENIZED_COMMUNITY
/createTokenCommunity
/packages/commonwealth/client/scripts/views/pages/LaunchToken/useCreateCommunity.ts
and add your currently logged-in Ethereum wallet address for thesetSelectedAddress
state - this is only temporary for testing - the actual address selection happens in step 1 of this flowDeployment Plan
N/A
Other Considerations
N/A