-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors delete comment #9232
Refactors delete comment #9232
Conversation
packages/commonwealth/client/scripts/state/api/comments/deleteComment.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thread/comment creation/deletion/voting works for me but when editing a thread/comment, version history selector is removed and it only shows the date-time of latest edit. cc: @Rotorsoft |
This is an issue in the schemas... .Thread and Comment are missing version histories field... thinking about fixing it in #9256 to avoid making changes in 3 open PRs... I've been merging all open PRs to move faster, but when issues are found in reviews it creates a lot of extra work 🤯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue with version history exists on master as well.
yep, fixed in #9256 |
Link to Issue
Closes: #9198
Description of Changes
"How We Fixed It"
Test Plan
Deployment Plan