Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors delete comment #9232

Merged
merged 9 commits into from
Sep 18, 2024
Merged

Refactors delete comment #9232

merged 9 commits into from
Sep 18, 2024

Conversation

Rotorsoft
Copy link
Contributor

Link to Issue

Closes: #9198

Description of Changes

  • Refactors old endpoint
  • Refactors bot integration

"How We Fixed It"

Test Plan

  • Can delete comments
  • Can delete bot comments

Deployment Plan

  • Deploy discord bot

Copy link
Contributor

@mzparacha mzparacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thread and comment creation is failing for me

image

Couldn't try delete comment (not able to create one to delete)

@Rotorsoft
Copy link
Contributor Author

Thread and comment creation is failing for me

image Couldn't try delete comment (not able to create one to delete)

I noticed some changes to the canvas interface I had to merge in this PR, mainly canvas hash was replaced with canvas message id... not sure if this is related to that... will look on my end

Copy link
Collaborator

@timolegros timolegros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API to delete comments works but the UI doesn't remove the comment until I refresh. Additionally, the following errors are logged in the client console when deleting a comment:
image

@mzparacha
Copy link
Contributor

Thread/comment creation/deletion/voting works for me but when editing a thread/comment, version history selector is removed and it only shows the date-time of latest edit.

cc: @Rotorsoft

@Rotorsoft
Copy link
Contributor Author

Thread/comment creation/deletion/voting works for me but when editing a thread/comment, version history selector is removed and it only shows the date-time of latest edit.

cc: @Rotorsoft

This is an issue in the schemas... .Thread and Comment are missing version histories field... thinking about fixing it in #9256 to avoid making changes in 3 open PRs... I've been merging all open PRs to move faster, but when issues are found in reviews it creates a lot of extra work 🤯

Copy link
Collaborator

@timolegros timolegros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with version history exists on master as well.

@Rotorsoft
Copy link
Contributor Author

The issue with version history exists on master as well.

yep, fixed in #9256

@Rotorsoft Rotorsoft merged commit 261ae5f into master Sep 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🟦 DeleteComment
4 participants