Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require federation db for local testing #9234

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Don't require federation db for local testing #9234

merged 1 commit into from
Sep 16, 2024

Conversation

raykyri
Copy link
Collaborator

@raykyri raykyri commented Sep 16, 2024 •
edited
Loading

Link to Issue

Closes: #9235

Description of Changes

  • Start Canvas node with an in-memory database if no federation database URL is provided, and APP_ENV is local.

"How We Fixed It"

Test Plan

  • Start application
  • Create a thread and comment and note the logical clock incrementing.

Deployment Plan

Other Considerations

@github-actions github-actions bot marked this pull request as draft September 16, 2024 17:28
@raykyri raykyri marked this pull request as ready for review September 16, 2024 17:31
@raykyri raykyri merged commit 0c336e9 into master Sep 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timolegros timolegros timolegros approved these changes

@Rotorsoft Rotorsoft Rotorsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't run Commonwealth without federation database in local development
3 participants
@raykyri @Rotorsoft @timolegros