Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment, thread creation #9237

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix comment, thread creation #9237

merged 1 commit into from
Sep 16, 2024

Conversation

raykyri
Copy link
Collaborator

@raykyri raykyri commented Sep 16, 2024

Thread and comment creation was failing when a trailing newline or a URL-encoded character was created.

Link to Issue

Closes: #9236

Description of Changes

  • Adds FIXME widget to TODO page.

"How We Fixed It"

Test Plan

  • Unit tested the FIXME() call.
  • CA (click around) tested on local and frack:
    • TODO page

Deployment Plan

Other Considerations

@raykyri
Copy link
Collaborator Author

raykyri commented Sep 16, 2024

There is still a call in libs/model/src/utils/decodeContent.ts that was added in the last few days which I haven't touched.

It doesn't affect thread/comment creation but could cause us trouble in the future: return rawMarkdown.trim();

@timolegros
Copy link
Collaborator

There is still a call in libs/model/src/utils/decodeContent.ts that was added in the last few days which I haven't touched.

It doesn't affect thread/comment creation but could cause us trouble in the future: return rawMarkdown.trim();

@raykyri we should standardize how we parse content for canvas/API. As it stands canvas will sign Quill Deltas whereas raw markdown is what is actually stored in the DB so the canvas signed content doesn't match the actual stored content.

@raykyri raykyri merged commit 81f1869 into master Sep 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create threads with trailing newlines
3 participants