-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode Content Clean-up #9251
Decode Content Clean-up #9251
Conversation
# Conflicts: # libs/model/src/thread/UpdateThread.command.ts
This PR is technically ready (minus any conflicts) but cannot be merged until the decoding scripts from #9183 are executed in production. Will leave this PR in draft until then. |
# Conflicts: # libs/model/src/comment/UpdateComment.command.ts # libs/model/src/thread/UpdateThread.command.ts # packages/commonwealth/client/scripts/state/api/comments/deleteComment.ts # packages/commonwealth/scripts/decode-db-content.ts # packages/commonwealth/server/routes/feed.ts
@mzparacha tagging you here for review to ensure we don't regress on #8611 |
6214721
to
4425189
Compare
# Conflicts: # packages/commonwealth/client/scripts/views/pages/discussions/ThreadCard/ThreadCard.tsx
sry I missed this, will review early tomorrow |
Tested #8611 and it works well for me on iOS safari. Would like @masvelio to take a look as well.
cc: @timolegros |
Update: 2 from #9251 (comment) is resolved after running content decode scripts (TY @timolegros). I wasn't able to repro 1 from #9251 (comment) in the master branch + the markdown doesn't render there correctly cc: @burtonator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown bug was with the new editor, everything works well. TY for all the changes
Link to Issue
Closes: #9184
Description of Changes
plaintext
andbody_backup
columns"How We Fixed It"
Test Plan
Create threads with a variety of formats (using markdown) and ensure the thread previews appear normal
Important: Ensure Thread preview on mobile appears broken #8611 is not reintroduced.
Context:
I replaced
thread.plaintext.replaceAll(/\n/g, '').slice(0, 150)
withthread.body
which is raw markdown that may contain/n
.Using the previously created thread, create a snapshot proposal. Images should be removed but all markdown should be properly rendered.
Deployment Plan
Other Considerations