-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the logic of show more from number of lines to number characters #9452
base: master
Are you sure you want to change the base?
Conversation
packages/commonwealth/client/scripts/views/pages/discussions/ThreadCard/ThreadCard.tsx
Outdated
Show resolved
Hide resolved
Screen.Recording.2024-10-10.at.1.39.06.PM.movafter resolving the conflict |
@KaleemNeslit what's the status here? Please make sure that PRs do not getting stale. It's your responsibility to merge it as soon as possible 🙏 |
… into kaleemNeslit.9276.showMore
@masvelio , this PR needs review. I have addressed the comments and requested reviews from 4 people, but 2 are still pending, even though it's been many days. |
@masvelio @Israellund @burtonator @mzparacha Whenever you have a chance, could you please review my PR? It's been in a stale state for a few days. Thanks! |
@mzparacha could you take a look on this one? |
Noticed some inconsistencies b/w the master and the current implementation. Current: Screen.Recording.2024-10-25.at.6.37.35.PM.movMaster: Screen.Recording.2024-10-25.at.6.39.04.PM.movJust for more context: this quill text cutoff has historically caused many inconsistencies b.w devices (iOS safari for instance #8611) and thread bodies (some of which you can see in the cc: @KaleemNeslit |
|
Lets aim to fix the multiline \n and markdown issues (plz compare the threads in videos for reference). |
updates we need to update some logic related to the cutofflines and maxChars so i am converting PR as draft to implement the requirements |
Link to Issue
Closes: #9276
Description of Changes