-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed the crash issue on search bar in thread #9481
Conversation
@masvelio @mzparacha I would like to hear what you think about this PR. Is this something you would recommend to fix this, or is there something else already in place that Kaleem should use? |
Generally works, but the dashboard page hands for me if there are threads with > 1K+ chars in the home feed. cc: @KaleemNeslit |
@mzparacha i will check that as well |
showMore.mov@mzparacha i test it with 7K character working well . |
@KaleemNeslit plz try on |
@mzparacha working fine for me Screen.Recording.2024-10-11.at.9.57.03.PM.mov |
@Israellund @masvelio @mzparacha i need one more approve to merge this pr it's working fine for me |
I am getting some db issues, can you please merge master. cc: @KaleemNeslit |
… into kaleemNeslit.9279.search_break
@mzparacha i merge the master kindly review it |
Link to Issue
Closes: #9279
Description of Changes
"How We Fixed It"
The issue was resolved by implementing a function (escapeRegExp) to escape special characters in the search terms. This ensures that special characters are treated as literal strings rather than part of a regular expression.
N/A
Screen.Recording.2024-10-08.at.7.46.28.PM.mov