Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the crash issue on search bar in thread #9481

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

KaleemNeslit
Copy link
Collaborator

Link to Issue

Closes: #9279

Description of Changes

  • the rise from the npm package "highlight-words-core" in findAll function
  • The issue was resolved by implementing a function (escapeRegExp) to escape special characters in the search terms.

"How We Fixed It"

The issue was resolved by implementing a function (escapeRegExp) to escape special characters in the search terms. This ensures that special characters are treated as literal strings rather than part of a regular expression.

N/A

Screen.Recording.2024-10-08.at.7.46.28.PM.mov

@Israellund
Copy link
Collaborator

@masvelio @mzparacha I would like to hear what you think about this PR. Is this something you would recommend to fix this, or is there something else already in place that Kaleem should use?
@KaleemNeslit Please also assign Malik @mzparacha for PR reviews on all of your PRs as well as myself, Marcin, and Kevin.

@mzparacha
Copy link
Contributor

mzparacha commented Oct 9, 2024

Generally works, but the dashboard page hands for me if there are threads with > 1K+ chars in the home feed.

cc: @KaleemNeslit

@KaleemNeslit
Copy link
Collaborator Author

Generally works, but the dashboard page hands for me if there are threads with > 1K+ chars in the home feed.

cc: @KaleemNeslit

@mzparacha i will check that as well

@KaleemNeslit
Copy link
Collaborator Author

Generally works, but the dashboard page hands for me if there are threads with > 1K+ chars in the home feed.
cc: @KaleemNeslit

@mzparacha i will check that as well

showMore.mov

@mzparacha i test it with 7K character working well .

@mzparacha
Copy link
Contributor

@KaleemNeslit plz try on /dashboard/global page

@KaleemNeslit
Copy link
Collaborator Author

/dashboard/global

@mzparacha working fine for me

Screen.Recording.2024-10-11.at.9.57.03.PM.mov

@KaleemNeslit
Copy link
Collaborator Author

@Israellund @masvelio @mzparacha i need one more approve to merge this pr it's working fine for me

@mzparacha
Copy link
Contributor

I am getting some db issues, can you please merge master.

cc: @KaleemNeslit

@KaleemNeslit
Copy link
Collaborator Author

I am getting some db issues, can you please merge master.

cc: @KaleemNeslit

@mzparacha i merge the master kindly review it

@KaleemNeslit KaleemNeslit merged commit 07caf58 into master Oct 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching for a thread and adding \ breaks page
5 participants