updated 404/PageNotFound #9503
Merged
updated 404/PageNotFound #9503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masvelio
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
the problem is that we treat every 404 page the same way.
This address from video does not exists but even though I got info about private page and prompt to sign in. After signing in, I am still on 404.
Kapture.2024-10-10.at.12.22.28.mp4
The idea is cool but to make it truly work, it needs much more effort.
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9486
Description of Changes
Test Plan
-go to
/404-confirm that you now see the changed copy.
-click the Sign in button below the copy and confirm you see the AuthModal
-Sign in as you regularly would and confirm that it worked