Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor user activity queries #9526

Merged
merged 19 commits into from
Oct 15, 2024
Merged

Refactor user activity queries #9526

merged 19 commits into from
Oct 15, 2024

Conversation

Rotorsoft
Copy link
Contributor

@Rotorsoft Rotorsoft commented Oct 10, 2024

Link to Issue

Closes: #9507

⚠️ Don't look at api-client autogenerated code (most files in diff)

Description of Changes

  • Refactors user activity queries
  • Exposed in external router

"How We Fixed It"

Test Plan

  • User activity is displayed

Deployment Plan

Other Considerations

Copy link
Collaborator

@timolegros timolegros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good though I have questions around authentication for the feed queries.

libs/model/src/feed/GetUserActivity.query.ts Outdated Show resolved Hide resolved
libs/model/src/feed/GetUserActivity.query.ts Outdated Show resolved Hide resolved
@Rotorsoft Rotorsoft requested a review from timolegros October 15, 2024 14:23
@Rotorsoft Rotorsoft merged commit 8aef5b5 into master Oct 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🟩 GetUserActivity, GetGlobalActivity, GetThreads
3 participants