Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the edit of thread from other screens #9545

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

KaleemNeslit
Copy link
Collaborator

Link to Issue

Closes: #9274

Description of Changes

  • In url I pass the isEdit params so we can know user want to edit the thread ,
  • navigate(${discussionLink}?isEdit=true)

"How We Fixed It"

  • when user select edit thread in overView or other pages we pass the "isEdit" params in url so we can know user want to edit the thread

Test Plan

N/a

Deployment Plan

N/A

Other Considerations

Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve my comments, works good, thanks! approving in advnace

Copy link
Contributor

@mzparacha mzparacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@KaleemNeslit KaleemNeslit merged commit 7f029e6 into master Oct 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing thread from All/Overview doesn't open in edit mode
3 participants