Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hazim/feature/table dialog #25

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Hazim/feature/table dialog #25

merged 7 commits into from
Oct 3, 2023

Conversation

ZimLim
Copy link
Contributor

@ZimLim ZimLim commented Oct 2, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Used Modal component to have summary table as pop up
  • Changed download buttons' description to be color blind-friendly
  • Clicking 'Apply Filter' will cause the table to pop up

Checklist

  • This PR can be reviewed in under 30 minutes
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have assigned reviewers to this PR.

@ZimLim ZimLim requested a review from wenhwang97 October 2, 2023 20:35
@ZimLim ZimLim force-pushed the hazim/feature/table-dialog branch from b4a5655 to b9118c2 Compare October 3, 2023 20:36
Copy link
Collaborator

@wenhwang97 wenhwang97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid!

@ZimLim ZimLim merged commit 72c5c43 into main Oct 3, 2023
@ZimLim ZimLim deleted the hazim/feature/table-dialog branch October 3, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants