Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for a common JSON transaction parameters object #208

Closed
rwalworth opened this issue May 15, 2024 · 1 comment · Fixed by #209
Closed

Add documentation for a common JSON transaction parameters object #208

rwalworth opened this issue May 15, 2024 · 1 comment · Fixed by #209
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@rwalworth
Copy link
Contributor

An issue was noticed while working on hiero-ledger/hiero-sdk-cpp#695 (with #205) that it isn't exactly clear when an additional signature should be applied to a transaction for some tests. The use of the signerKey field should be used to explicitly provide the keys that should sign a transaction.

@rwalworth rwalworth added the enhancement New feature or request label May 15, 2024
@rwalworth rwalworth added this to the Sprint 6 milestone May 15, 2024
@rwalworth rwalworth self-assigned this May 15, 2024
@rwalworth rwalworth added documentation Improvements or additions to documentation and removed enhancement New feature or request labels May 15, 2024
@rwalworth rwalworth changed the title Use signerKey as a way to ensure additional signatures in AccountCreateTransaction Add documentation for a common JSON transaction parameters object May 22, 2024
@rwalworth
Copy link
Contributor Author

In addition to allowing signerKeys to be a list and an explicit way to provide extra signatures to a transaction, the scope of this issue is being expanded to create and document a JSON object which will contain all common transaction parameters which can easily be added to our JSON-RPC APIs. This object should include transactionId, maxTransactionFee, etc. This will allow us to test these properties going forward and keeping them documented and consolidated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
2 participants