docs: create commonTransactionParameters to hold parameters that are common between all transaction types
#209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalworth
requested review from
SimiHunjan,
0xivanov,
RickyLB,
agadzhalov,
Petyo-Lukanov,
svetoslav-nikol0v and
gsstoykov
rwalworth
changed the title
signerKeys to explicitly state when additional keys should sign a transactionsignerKeys to explicitly state when additional keys should sign an AccountCreateTransaction
… transaction Signed-off-by: Rob Walworth <[email protected]>
rwalworth
force-pushed
the
00208-use-signerkey-as-a-way-to-ensure-additional-signatures-in-accountcreatetransaction
branch
from
0dde811
to
0e65def
Compare
thenswan
reviewed
May 20, 2024
…_PRIVATE_KEY or VALID_PUBLIC_KEY Signed-off-by: Rob Walworth <[email protected]>
2 tasks
…t are common between all transactions Signed-off-by: Rob Walworth <[email protected]>
rwalworth
changed the title
signerKeys to explicitly state when additional keys should sign an AccountCreateTransaction
rwalworth
changed the title
commonTransactionParameters to hold parameters that are common between all transaction types
rwalworth
added
documentation
rwalworth
added a commit
that referenced
this pull request
May 23, 2024
Signed-off-by: Rob Walworth <[email protected]>
thenswan
approved these changes
May 28, 2024
|
@rwalworth will |
Yes, the |
rwalworth
deleted the
00208-use-signerkey-as-a-way-to-ensure-additional-signatures-in-accountcreatetransaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- UpdatesignerKeyto a list that will allow for multiple additional signatures of a transaction- Explicitly usesignerKeysto provide any additional signatures to a transaction. The transaction will not be signed (except by the fee payer) ifsignerKeysis empty.While working on #216, I noticed an issue that would need to be addressed at some point: common parameters for all transactions. I decided to hijack this PR with a proposed solution since it was already addressing an issue that was tangent to it. Basically in order to allow ourselves to test all fields for a transaction (most notably, the parameters that are common to all transactions), we would need to add all of these parameters
This PR now adds the specification for an additional JSON parameter object that can be shared between transactions,
commonTransactionParams. This will allow every transaction to hold common parameters in one defined object, as well as hold signatures (which was this PR's original intent).signerKeyis nowsigners, and is a list contained incommonTransactionParams. The transaction will now not be signed (except by the fee payer established with thesetOperatormethod) ifcommonTransactionParams.signersis empty.Related issue(s):
Fixes #208