Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reverse data attribute #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sintanial
Copy link

Added data attribute data-graph-reverse.
Can be used for example when table ordered desc by date but we need line graph by date with ordered by asc.

@@ -195,6 +195,11 @@
var isGraphDatetime = $table.data('graph-xaxis-type') == 'datetime';

var rows = $('tbody:first tr', table);

if (!!$table.data('graph-reverse')){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the double "!!" ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's short boolean check for true

@agallou
Copy link
Member

agallou commented Nov 1, 2015

@sintanial this seams a very specific usage, witch does not have to be in the lib.
Instead an event to update the rows could be useful to more people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants