Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit mode #96

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

Edit mode #96

wants to merge 54 commits into from

Conversation

TorsteinHonsi
Copy link
Contributor

@TorsteinHonsi TorsteinHonsi commented Dec 12, 2024

Edit source code directly in Utils. Replaced the View source pane with Edit, that allows us to edit, run and save. Also allows Save As..., which is a convenient way of copying demos.

@TorsteinHonsi TorsteinHonsi changed the title edit Edit mode Dec 12, 2024
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I love it!

A few things though:

  • - Update readme.md about the new way to start the server
  • - enter edit mode, exit edit mode, click Bisect button: the bisect frame lands somewhere below everything
image

Nice to have:

  • - when quitting Edit mode, it would be nice to NOT reload the list of demos, it takes on my machine extra ~10s when I just wait and watch loading the sidemenu, then scrolling it way to the bottom:
    scroll

@pawelfus
Copy link
Contributor

(the above should be request changes, not a comment - just a misclick)

@TorsteinHonsi
Copy link
Contributor Author

Done, except this one:

Update readme.md about the new way to start the server

I didn't think of the case when the server is started with sudo node server. I tried to call Rollup from server.js, but it currently fails with a syntax error. Will try to make it work.

@TorsteinHonsi TorsteinHonsi mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants